Expose network context to requestHook & responseHook scopes #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation should be updated (https://support.insomnia.rest/article/26-plugins#context.response / https://support.insomnia.rest/article/26-plugins#context.request) but I don't know how to update it 😅 |
I've noticed inconsistency on naming between `_applyRequestPluginHooks` and `_applyResponsePluginHooks` parameters.
jgiovaresco
force-pushed
the
fix/2012-expose-network-context
branch
from
c370863 to
76590b2
Compare
develohpanda
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Looks good to me 👍
What part of the documentation needs to be updated? Docs are hosted on HelpScout for various reasons, but if you post a diff/changes into a comment here I can go ahead and update HelpScout with it. (I don't think there are any changes required but I might be missing something)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue #2012 was talking about exposing the
networkcontext to theresponseHookscope to be able to send new request from there.I took the opportunity to expose the
networkcontext to therequestHookalso to be able to send request in request hook. Personally I am interested by this to create a plugin to login automatically to a private api. If you prefer I can move the commit in another PR ;)Closes #2012