Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export import unit tests #2663

Merged
merged 7 commits into from
Sep 25, 2020
Merged

Export import unit tests #2663

merged 7 commits into from
Sep 25, 2020

Conversation

sonicyeti
Copy link
Contributor

This PR covers the importing & exporting of unit test suites, tests and results. Video demo can be seen here:

https://share.getcloudapp.com/4guJQJjQ

Closes: #2619
FIXES INS-75

@sonicyeti sonicyeti added the B-bug Bug: general classification label Sep 24, 2020
@sonicyeti sonicyeti self-assigned this Sep 24, 2020
@linear
Copy link

linear bot commented Sep 24, 2020

INS-75 Unit tests lost after export -> import

  • Connect to Git (used gitlab)
  • Commit everything
  • Delete document
  • Clone
  • Unit tests missing

Expected result

  • Unit tests to be shown under test tab

See comments

develohpanda
develohpanda suggested changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 😄 I don't think we should be exporting unit test results, though, so a small change to make please!

develohpanda
develohpanda reviewed Sep 24, 2020
View reviewed changes
Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, almost there!

@netlify
Copy link

netlify bot commented Sep 24, 2020

Deploy preview for insomnia-storybook ready!

Built with commit e40a4db

https://deploy-preview-2663--insomnia-storybook.netlify.app

@develohpanda develohpanda merged commit 19a9d6a into develop Sep 25, 2020
@develohpanda develohpanda deleted the export-import-unit-tests branch September 25, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@develohpanda develohpanda develohpanda approved these changes

@DMarby DMarby Awaiting requested review from DMarby

Assignees

@sonicyeti sonicyeti

Labels
B-bug Bug: general classification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests are lost when exported
2 participants
@sonicyeti @develohpanda