Fix select all with large response

[jgiovaresco]

Closes #2478, Closes INS-921

[develohpanda]

Hmm, thanks for trying this. Both aren't ideal, one covers text and the other adds a lot of blank space. I'm not quite sure what the best option for this is, yet.

[jgiovaresco]

I will try to add an action in the Preview dropdown to copy the response data in the clipboard.

[develohpanda]

I will try to add an action in the Preview dropdown to copy the response data in the clipboard.

👍

@nijikokun / @erickrico if you have any feedback here that'd be awesome. Some context in #2478. tl;dr is, the ctrl + a select-all action is quite slow when selecting a large response (due to CodeMirror), so an option is to put a copy-to-clipboard button somewhere, but we are unsure on UI placement. There are some options suggested in the issue as well.

[jgiovaresco]

I've added an action Copy raw response in the Preview dropdown

[nijikokun]

The above, inside the dropdown, seems like a good solution for now. That said, I do fear that it might be hidden and a user will encounter the same issue that was originally raised inside of #2478.

My personal opinion on the placement (to avoid overlap and gaps) is to place it here:

Or here:

cc @erickrico

[jgiovaresco]

It looks like this when the button in the Response pane header

[develohpanda]

My two cents:

Placing it in the top header disconnects it from what it relates to. Additionally, the copy button is also quite closely tied to which response viewer is currently shown. If the PDF viewer is shown, the copy button doesn't apply, but it does apply for JSON and raw viewers, for instance.

I don't have high hopes for this, but if it's at all possible to wrap text around the button, should it ever be in a position to overlap, that'd be awesome (see gif here). It will need investigation into CodeMirror to determine whether it is achievable.

[erickrico]

My two cents:

Placing it in the top header disconnects it from what it relates to. Additionally, the copy button is also quite closely tied to which response viewer is currently shown. If the PDF viewer is shown, the copy button doesn't apply, but it does apply for JSON and raw viewers, for instance.

I don't have high hopes for this, but if it's at all possible to wrap text around the button, should it ever be in a position to overlap, that'd be awesome (see gif here). It will need investigation into CodeMirror to determine whether it is achievable.

i agree, especially if the copy button disappear one you switch to a different tab (header cookies, timeline) i would suggest to keep it under the "preview dropdown"

[nijikokun]

I agree with the discussions above, let's keep in the dropdown for now. Given that we are also on an older version of codemirror this might be resolved when we upgrade in the future.

[develohpanda]

We are making an effort to work through our open-source PRs, sorry about the big delays! I updated this branch with develop and QA'd with the test files available here: https://code.google.com/archive/p/jquery-speedtest/downloads.

LGTM! Works as intended. The fact that we can handle/work with 100mb responses with a similar responsiveness (pun intended) to VS Code is promising, and the copy raw response appears to be working well. https://www.loom.com/share/bce854e46d734e98a5ea25d325e50c5a

Thank you for your hard work 🙌🏽

[gatzjames]

🚀