Don't clear oAuth2 session on restart

[KarolineKarkosch]

Offer button to user where it can be cleared without restart

Closes #1550

[develohpanda]

Nice! I generally like this, I think it would be beneficial for folks who have different workflows.

I have a couple of observations from the implementation though, could you please check the behavior? 😄

[develohpanda]

Progress! 😄

[develohpanda]

Given we want to make it opt-in for people to disable the clearing of the OAuth session on startup, here's what you'll need:

1. a new property in the settings (use "Follow Redirects" as an example for linking the checkbox to a database property
2. conditionally clear the token on launch

For the second item: looking at main.development.js (app entry point), there is logic to initialize the database, and then initialize the app in _launchApp().

insomnia/packages/insomnia-app/app/main.development.js

Lines 36 to 50 in 03d83a8

	// When the app is first launched
	app.on('ready', async () => {
	// Init some important things first
	await database.init(models.types());
	await errorHandling.init();
	await windowUtils.init();
	// Init the app
	await _trackStats();
	await _launchApp();
	// Init the rest
	await updates.init();
	});

Before/during/after the _launchApp() invocation, you should be able to load the setting from the database and clear if necessary.

const settings = await models.settings.getOrCreate();

if (settings.clearOAuthSessionOnStart) {
	clearOAuthSession();
}

Please reach out if you need any help! Thanks for working through this 🤗

[KarolineKarkosch]

Given we want to make it opt-in for people to disable the clearing of the OAuth session on startup, here's what you'll need:

1. a new property in the settings (use "Follow Redirects" as an example for linking the checkbox to a [database property](https://github.com/Kong/insomnia/blob/03d83a8f52f9d9f4d4f38e014d406a95ef1d2611/packages/insomnia-app/app/models/settings.js#L86)

2. conditionally clear the token on launch

For the second item: looking at main.development.js (app entry point), there is logic to initialize the database, and then initialize the app in _launchApp().

insomnia/packages/insomnia-app/app/main.development.js

Lines 36 to 50 in 03d83a8

	// When the app is first launched
	app.on('ready', async () => {
	// Init some important things first
	await database.init(models.types());
	await errorHandling.init();
	await windowUtils.init();
	// Init the app
	await _trackStats();
	await _launchApp();
	// Init the rest
	await updates.init();
	});

Before/during/after the _launchApp() invocation, you should be able to load the setting from the database and clear if necessary.

const settings = await models.settings.getOrCreate();

if (settings.clearOAuthSessionOnStart) {
	clearOAuthSession();
}

Please reach out if you need any help! Thanks for working through this hugs

Thanks for your advice. I tried to implement it as you described but it seems to me as if the task in main.development runs in a different thread than where I am trying to use oauth2/misc.js. When I set the currentSessionId in _launchApp it is still undefined when the OAuth2 window is opened. Also console.logs inside misc.js go into the terminal console when calling functions from launchApp and to the browser console when I later try to access the value which furthers my suspicion that they are running in different environments. Additionally window is not yet defined at that point, so localstorage is not usable at all.
So I moved the initialization from settings to ui/index.js where I saw that for example themes or fonts are initialized from settings as well. I hope that is ok too.
It now works as expected: Depending on the clearOnRestart-Setting the session is deleted or not after starting and when using the sessionClear button the last session is persisted for after restart.

Also I fixed the styling per your suggestion, this is what it currently looks like:

[develohpanda]

Also console.logs inside misc.js go into the terminal console when calling functions from launchApp and to the browser console

Nice sleuthing, that seems to make sense. When I was looking through that code, I noticed that windowUtils.init() was also initializing local storage, so thought it should be available at that point. I think main.development.js is the electron entry point and ui/index.js is the entry point for the web application being run in electron, so that might explain the differences.

It looks like you've put it in the right place now! 😃

[develohpanda]

Code looks good to me, thank you for working through this!

[develohpanda]

Nice comment, some additional context here

[DMarby]

Very nice, thanks for your contribution! 👍