Add export as HAR format for single requests #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beardeddragon5
changed the title
|
|
dimitropoulos
force-pushed
the
export-request-as-har
branch
from
f372985
to
8f83cd0
Compare
dimitropoulos
requested review from
develohpanda,
dimitropoulos and
gatzjames
and removed request for
dimitropoulos
develohpanda
approved these changes
Sep 22, 2021
and adds some consistency while we're at it
I was on my way to writing some tests to cover the things addressed in this PR. I was happy to see that we already covered what I was planning to test. However, there were some very surface-level type errors in the tests so I thought it appropriate to fix them while I was in this area of the code for this job.
dimitropoulos
force-pushed
the
export-request-as-har
branch
from
8f83cd0
to
b8eae1f
Compare
gatzjames
approved these changes
Sep 22, 2021
|
|
||
| const workspaceMeta = await models.workspaceMeta.getByParentId(workspace._id); | ||
| let environmentId = workspaceMeta ? workspaceMeta.activeEnvironmentId : null; | ||
| const environment = await models.environment.getById(environmentId || 'n/a'); |
There was a problem hiding this comment.
Curious why is n/a needed here? Is it a pattern we use often or specific to this method?
There was a problem hiding this comment.
It's just a remnant of the past, especially when flow was a thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #650