Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unescape xml links before opening it #2725

Merged
merged 5 commits into from
Sep 9, 2021

Conversation

jgiovaresco
Copy link
Contributor

Closes #908

in response-viewer: I had to extract _getMode in order to use it in the click link handler.  To do that, though, I needed to also extract _getBody.  As I did that, I saw that character-for-character code for creating the body was duplicated all around the file.  So I removed that duplication while I was here (along with reduced the else-return complexity).  This then illuminated that the only place _decodeIconv was being called was (now) in the _getBody method, which meant that it could be inlined.
Copy link
Contributor

@gatzjames gatzjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works great! 👍

…r.tsx

Co-authored-by: James Gatz <jamesgatzos@gmail.com>
@dimitropoulos dimitropoulos enabled auto-merge (squash) September 9, 2021 14:42
@dimitropoulos dimitropoulos merged commit d4da3ad into Kong:develop Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escape XML entities out of XML links before calling browser
4 participants