Unescape xml links before opening it#2725
Merged
dimitropoulos merged 5 commits intoKong:developfrom Sep 9, 2021
Merged
Conversation
jgiovaresco
force-pushed
the
fix/908-unescape-xml-links
branch
5 times, most recently
from
d0e3ed1 to
09bee3f
Compare
in response-viewer: I had to extract _getMode in order to use it in the click link handler. To do that, though, I needed to also extract _getBody. As I did that, I saw that character-for-character code for creating the body was duplicated all around the file. So I removed that duplication while I was here (along with reduced the else-return complexity). This then illuminated that the only place _decodeIconv was being called was (now) in the _getBody method, which meant that it could be inlined.
dimitropoulos
force-pushed
the
fix/908-unescape-xml-links
branch
from
09bee3f to
a4408c7
Compare
gatzjames
approved these changes
Sep 9, 2021
…r.tsx Co-authored-by: James Gatz <jamesgatzos@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #908