Rename button label of the Save and Download action save dialog
#2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch, the request is sent prior to the dialog showing, this is a great change 👍 |
nijikokun
approved these changes
Oct 15, 2020
jgiovaresco
force-pushed
the
reword-send-and-download-button
branch
2 times, most recently
from
74617ca
to
d5e248b
Compare
develohpanda
approved these changes
Oct 20, 2020
The label was `Send and Save`, it is confusing because actually the request was already sent.
jgiovaresco
force-pushed
the
reword-send-and-download-button
branch
from
d5e248b
to
44a2302
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The label was
Send and Save, it is confusing because actually the request was already sent.Before
After
Related to #2721