Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request History: Set dropdown value to the response instead of null #2735

merged 2 commits into from Aug 31, 2021


Copy link

@thewheat thewheat commented Oct 17, 2020

Before (current broken behaviour)

After (which this fix)

Context of the bug

  • So the bug is due to this section of code
    return (
    <DropdownDivider>5 Minutes Ago</DropdownDivider>
    <DropdownDivider>2 Hours Ago</DropdownDivider>
    <DropdownDivider>This Week</DropdownDivider>
    <DropdownDivider>Older Than This Week</DropdownDivider>
  • Each .map will start at index of 0 so the first item in the new grouping would cause the issue

Copy link

CLAassistant commented Dec 6, 2020

CLA assistant check
All committers have signed the CLA.

Copy link

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this and my apologies for the delay in review, it's been quite challenging to keep up with open-source PRs, but the team is working on it. We really appreciate your time! 🙌🏽

Verified as fixed in this PR, and broken in the current stable release.

@develohpanda develohpanda enabled auto-merge (squash) August 31, 2021 06:00
@develohpanda develohpanda merged commit 84fc8f3 into Kong:develop Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
4 participants