-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix Copy as CURL with Multipart #2740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Copy as CURL with Multipart #2740
Conversation
Awesome change, I assume this works for multi-file as well? |
9791a6f
to
e2497b6
Compare
You are assuming right ;)
|
ca1d812
to
590211a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes sense to me.
590211a
to
51710e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for the delay in getting to this!
51710e1
to
03a4880
Compare
The issue was located in the `exportHar` function. It was not handled `file` param correctly. For this type of file, the `value` attribute is empty, therefore we should take instead the `fileName` Closes Kong#2282
03a4880
to
ef24f72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this @jgiovaresco!
The issue was located in the
exportHar
function. It was not handledfile
param correctly.For this type of file, the
value
attribute is empty. Therefore we should take instead of thefileName
The issue also impacted the
Generate code
feature.Closes #2282
Before
After