Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insomnia core & designer app iconography #2766

Merged
merged 12 commits into from
Oct 22, 2020

Conversation

sonicyeti
Copy link
Contributor

@sonicyeti sonicyeti commented Oct 22, 2020

This PR covers the resolving of the designer logo being rendered in both Insomnia Core & Designer in both Linux and Windows.

Screenshot showing both Design & Core in Windows.

window_icons_core_designer

Closes #2672 #2345

Fixes INS-80

@sonicyeti sonicyeti added the B-bug Bug: general classification label Oct 22, 2020
@sonicyeti sonicyeti self-assigned this Oct 22, 2020
Copy link
Contributor

@DMarby DMarby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sonicyeti sonicyeti merged commit c081fd2 into develop Oct 22, 2020
@sonicyeti sonicyeti deleted the Insomnia-Core-App-Iconography branch October 22, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: general classification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong window icon for Insomnia Core on Windows
3 participants