Prevent GraphQL non breaking space #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewheat
commented
Oct 23, 2020
| @@ -804,16 +804,16 @@ class CodeEditor extends React.Component { | |||
| change.update(change.from, change.to, [text]); | |||
| } | |||
|
|
|||
| // Don't allow non-breaking spaces because they break the GraphQL syntax | |||
| if (doc.options.mode === 'graphql' && change.text && change.text.length > 0) { | |||
There was a problem hiding this comment.
change.text is an array of the text that is inputted with each element being a line of text that was entered
- most cases would just be a single line so
change.text.length== 1 - if
Enteris pressed or text with newline is pasted thenchange.text.lengthwill be greater than 1
|
|
|
Merged with latest develop and added more irregular characters that might break the interface.
|
dimitropoulos
approved these changes
Sep 1, 2021
develohpanda
reviewed
Sep 2, 2021
| @@ -990,7 +991,7 @@ class CodeEditor extends Component<Props, State> { | |||
| } | |||
| } | |||
|
|
|||
| _codemirrorValueBeforeChange(doc, change) { | |||
| _codemirrorValueBeforeChange(doc: CodeMirror.Editor, change: CodeMirror.EditorChangeCancellable) { | |||
There was a problem hiding this comment.
@gatzjames I believe we should be using CodeMirror.EditorFromTextArea instead of the generic CodeMirror.Editor; that's the only type of editor used AFAIK
| if (doc.getOption('mode') === 'graphql') { | ||
| const text = change.text.map(normalizeIrregularWhitespace); | ||
|
|
||
| change.update?.(change.from, change.to, text); |
There was a problem hiding this comment.
I think we shouldn't invoke update if text.length === 0 (ie. no lines)?
| @@ -0,0 +1,33 @@ | |||
| // List of irregular whitespace characters adopted from https://eslint.org/docs/rules/no-irregular-whitespace#rule-details | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://github.com/Kong/insomnia/pull/2704/files#r505491859 it was found that the code to prevent GraphQL non breaking spaces (that cause a syntax error) is not working
This PR fixes the behaviour
Demo