Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specification linting for files #2773

Merged
merged 4 commits into from Nov 24, 2020
Merged

Conversation

joemirizio
Copy link
Contributor

Closes #2769

Adds support for linting a local specification file (e.g. inso lint spec ./spec.yaml).

Lint steps

  1. Try to load from db
  2. Try to load from file. The file path is resolved in the same way as generate config.
  3. Trace log if the file path is blank or the file is not found and return false
  4. Log linting results and return success

@develohpanda develohpanda self-requested a review October 24, 2020 04:22
@joemirizio
Copy link
Contributor Author

@develohpanda no rush on the review, but would you consider adding the hacktoberfest-accepted label to this PR before the Oct 31st deadline?

@develohpanda
Copy link
Contributor

Hey @joemirizio! Because this repo is opted-in to Hacktoberfest, as long as we don't mark this PR as spam (which it isn't), it will count as a contribution. On you Hacktoberfest dashboard, it should mature after 14 days (which is the time they give to maintainers to mark as spam).

@joemirizio
Copy link
Contributor Author

Based on the FAQ and the update, I think PR's need to merged/approved by Nov 1st or hacktoberfest-accepted labeled. My dashboard lists it as "Pending" and does not show it maturing.

Pull requests in repositories with the ‘hacktoberfest’ topic will also need to be merged, approved by a maintainer, or labeled as ‘hacktoberfest-accepted’ in order to qualify. The deadline for completions, merging, labeling, and approving is November 1.

Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, some minor feedback!

@develohpanda
Copy link
Contributor

Based on the FAQ and the update, I think PR's need to merged/approved by Nov 1st or hacktoberfest-accepted labeled. My dashboard lists it as "Pending" and does not show it maturing.

Pull requests in repositories with the ‘hacktoberfest’ topic will also need to be merged, approved by a maintainer, or labeled as ‘hacktoberfest-accepted’ in order to qualify. The deadline for completions, merging, labeling, and approving is November 1.

Oh, this requirement for opted-in repos is news to me... No worries, I'll run through PRs today and add the appropriate label. I read this from the FAQ a few days ago and gathered a different understanding 😞

image

Thanks for letting me know!

@joemirizio
Copy link
Contributor Author

Ah I think my rebase messed up the review comment linking, but I was able to address everything.

Thanks for letting me know!

Absolutely! The rules this year got a little confusing, but I appreciate you applying the label across the project. I use Insomnia all the time and I'm glad I could contribute!

Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay! Looks good to me, did some QA locally as well 🙂

Copy link
Contributor

@DMarby DMarby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@develohpanda develohpanda merged commit cf04732 into Kong:develop Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inso lint cannot run against local file
3 participants