Strips newlines when parsing GraphQL curl command #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerrytan
force-pushed
the
issue-1825-bugfix-graphql-curl-conversion
branch
from
9a9027e
to
139ddbc
Compare
|
|
|
Deploy preview for insomnia-storybook ready! Built with commit 636f86a |
| export function newBodyGraphQL(rawBody: string): RequestBody { | ||
| try { | ||
| // Only strip the newlines if rawBody is a parsable JSON | ||
| JSON.parse(rawBody); |
There was a problem hiding this comment.
There's no other way to do this, and JSON.parse is the fastest way available, but it still is one of those things I want to mention - if anyone can think of a way to do this without JSON.parseing arbitrary inputs please say so. Sometimes in special cases there are ways around it, but from what I can tell this isn't one of those situations.
There was a problem hiding this comment.
I don't think this is one of the special cases either so JSON.parse seems like a reasonable approach to it.
dimitropoulos
approved these changes
Feb 8, 2021
|
Updated branch with |
develohpanda
approved these changes
Feb 9, 2021
develohpanda
changed the title
|
Thanks a lot for your help @dimitropoulos and @develohpanda |
gravyboat
pushed a commit
to gravyboat/insomnia
that referenced
this pull request
Feb 9, 2021
Co-authored-by: Eric Reynolds <reynolek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug where GraphQL curl command copied from Chrome is not parsed correctly.
To reproduce the bug:
Expected: user is presented with a valid GraphQL query
Actual: user is presented with an invalid GraphQL (bunch of \n characters)
Video of the problem: here
Video of the new behaviour after this fix: here
Closes #1825