GraphQL Explorer - Make text selectable#2954
Merged
develohpanda merged 2 commits intoKong:developfrom Dec 17, 2020
Merged
Conversation
Contributor
develohpanda
left a comment
develohpanda
left a comment
There was a problem hiding this comment.
Seems reasonable, thanks for raising a PR and explaining your process!
| -webkit-user-select: text; | ||
| -moz-user-select: text; | ||
| user-select: text; |
Contributor
There was a problem hiding this comment.
Because this is an electron only app and we don't need to think about other browsers yet, so it should be safe to omit the -webkit and -moz styles, just keeping the regular user-select. 🙂
Suggested change
| -webkit-user-select: text; | |
| -moz-user-select: text; | |
| user-select: text; | |
| user-select: text; |
Contributor
Author
There was a problem hiding this comment.
Thank you for the suggestion @develohpanda ! I just pushed the change.
lykims
force-pushed
the
feature/graphql-explorer-select-text
branch
from
0213452 to
a7b9bc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2899
By inspecting elements, the
user-selectwithnoneseems to come from the body.However, I don't think it cannot be removed or modified because all texts would be selected.
The next level for CSS change would be for the GraphQL Explorer.
