Conversation
| .map(tag => ({ | ||
| name: tag, | ||
| desciption: '', | ||
| description: '', |
There was a problem hiding this comment.
Looks like this is used only in importFolderItem() which expects it to be spelt correctly, but it's kind of a non-issue because the typo'd property didn't have any valid data in it to start with.
insomnia/packages/insomnia-importers/src/importers/swagger2.js
Lines 159 to 172 in c55279d
packages/insomnia-app/app/ui/components/codemirror/lint/openapi.js
Outdated
Show resolved
Hide resolved
apisaint
left a comment
There was a problem hiding this comment.
Not a maintainer or owner, but ran it locally and it works, looked through the source files to ensure variables work properly with the ones given and double checked the imports.
LGTM. Nice catches!
develohpanda
left a comment
There was a problem hiding this comment.
Thanks for the PR and updating with dev! 🙌🏽
|
(I just rebased it, will merge shortly) |
|
Not that I care, but your commit has erased my authorship. |
|
That's not right. I care. I'll try to fix right this moment. |
|
@jsoref Please confirm it's correct now. If not, please feel free to re-commit and push, of course. |
|
Looks good |
|
(just to say it out loud, I considered trying to fix authorship when I rebased it but it really looks like your github is a bot account, so I didn't bother for that reason. I've reassigned authorship for other PRs in this way in the past and I try to be good about it, but in this case I made a bad judgement call, my apologies). |
|
I'm very much a human. I'm developing an action and that entails a bot (@check-spelling-bot), but the fixes I propose involve at least a bit of human consideration. I'm just prolific. |
|
hahahah. prolific, indeed. |
|
thanks again for contributing @jsoref and good luck with your action! |
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at jsoref@900dc34#commitcomment-45648533
The action reports that the changes in this PR would make it happy: jsoref@679cc25
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.