Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #2976

Merged
merged 1 commit into from May 25, 2021
Merged

Spelling #2976

merged 1 commit into from May 25, 2021

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 5, 2021

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@900dc34#commitcomment-45648533

The action reports that the changes in this PR would make it happy: jsoref@679cc25

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

packages/insomnia-app/app/network/network.js Outdated Show resolved Hide resolved
packages/insomnia-components/components/svg-icon.js Outdated Show resolved Hide resolved
Comment on lines 125 to 126
desciption: '',
description: '',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vaguely scary?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is used only in importFolderItem() which expects it to be spelt correctly, but it's kind of a non-issue because the typo'd property didn't have any valid data in it to start with.

function importFolderItem(item, parentId) {
const hash = crypto
.createHash('sha1')
.update(item.name)
.digest('hex')
.slice(0, 8);
return {
parentId,
_id: `fld___WORKSPACE_ID__${hash}`,
_type: 'request_group',
name: item.name || 'Folder {requestGroupCount}',
description: item.description || '',
};
}

Copy link
Contributor

@apisaint apisaint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a maintainer or owner, but ran it locally and it works, looked through the source files to ensure variables work properly with the ones given and double checked the imports.

LGTM. Nice catches!

Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and updating with dev! 🙌🏽

@dimitropoulos
Copy link
Contributor

(I just rebased it, will merge shortly)

@jsoref
Copy link
Contributor Author

jsoref commented May 25, 2021

Not that I care, but your commit has erased my authorship.

@dimitropoulos
Copy link
Contributor

That's not right. I care. I'll try to fix right this moment.

@dimitropoulos
Copy link
Contributor

@jsoref Please confirm it's correct now. If not, please feel free to re-commit and push, of course.

@jsoref
Copy link
Contributor Author

jsoref commented May 25, 2021

Looks good

@dimitropoulos
Copy link
Contributor

(just to say it out loud, I considered trying to fix authorship when I rebased it but it really looks like your github is a bot account, so I didn't bother for that reason. I've reassigned authorship for other PRs in this way in the past and I try to be good about it, but in this case I made a bad judgement call, my apologies).

@jsoref
Copy link
Contributor Author

jsoref commented May 25, 2021

I'm very much a human. I'm developing an action and that entails a bot (@check-spelling-bot), but the fixes I propose involve at least a bit of human consideration. I'm just prolific.

@dimitropoulos
Copy link
Contributor

hahahah. prolific, indeed.

@dimitropoulos dimitropoulos merged commit 9006bab into Kong:develop May 25, 2021
@dimitropoulos
Copy link
Contributor

thanks again for contributing @jsoref and good luck with your action!

@jsoref jsoref deleted the spelling branch May 25, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants