Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes stream to unlock file #3015

Merged
merged 3 commits into from Mar 17, 2021

Conversation

outils-tiers-metafactory
Copy link
Contributor

Closes #1979 - It should resolve kong/insomnia issue by closing the writable stream with end()

It should resolve kong/insomnia issue Kong#1979
@develohpanda develohpanda self-requested a review January 21, 2021 11:15
@develohpanda develohpanda changed the title Closes #1979 - Closes stream to unlock file Closes stream to unlock file Jan 21, 2021
@netlify
Copy link

netlify bot commented Jan 29, 2021

Deploy preview for insomnia-storybook ready!

Built with commit df8b86e

https://deploy-preview-3015--insomnia-storybook.netlify.app

Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

Copy link
Contributor

@sonicyeti sonicyeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! 🎉

@develohpanda develohpanda merged commit 224cb13 into Kong:develop Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] PDF file saved from response remains locked until Insomnia is closed
4 participants