Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remember the last used import Uri #3018

Merged
merged 3 commits into from Jan 27, 2021

Conversation

sfabriece
Copy link
Contributor

Closes #3009

@develohpanda develohpanda self-requested a review January 22, 2021 09:55
Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🎉

packages/insomnia-app/app/ui/redux/modules/global.js Outdated Show resolved Hide resolved
@sfabriece sfabriece force-pushed the feature/rember-last-import-uri branch from 729a079 to bb35717 Compare January 25, 2021 12:00
@sfabriece
Copy link
Contributor Author

Moved changes to import-export.js @develohpanda

Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Looks to be working after QA as well. Nice one! 🎉

Note, this only persists in the import/export modal from Preferences. If using Designer, and on the homepage you choose to "Create" a document "From URL", it does not persist (which IMO is correct).

@develohpanda develohpanda merged commit 7d89bc5 into Kong:develop Jan 27, 2021
@sfabriece sfabriece deleted the feature/rember-last-import-uri branch January 27, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: remember last used URL in import
3 participants