Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating webpack configuration for development #3043

Merged
merged 2 commits into from Feb 3, 2021
Merged

Updating webpack configuration for development #3043

merged 2 commits into from Feb 3, 2021

Conversation

MrSnix
Copy link
Contributor

@MrSnix MrSnix commented Feb 3, 2021

I open this PR to update the Webpack configuration specifically for webpack.config.development.babel.js.

Insomnia is currently using Webpack v4, now in this release the following changes were introduced:

  • The notation new webpack.NoEmitOnErrorsPlugin() has been replaced by config.optimization.noEmitOnErrors
  • The notation new webpack.NamedModulesPlugin() has been replaced by config.optimization.namedModules
  • NamedModules is not necessary to be declared because this option is enabled by default for mode development

Webpack Documentation - v4:

@MrSnix MrSnix changed the title Updating webpack.config.development.babel.js Updating webpack configuration for development Feb 3, 2021
@develohpanda develohpanda self-requested a review February 3, 2021 06:33
develohpanda
develohpanda approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@develohpanda develohpanda merged commit c06b504 into Kong:develop Feb 3, 2021
@MrSnix MrSnix deleted the bug/deprecated-webpack-setting branch February 4, 2021 05:06
gravyboat pushed a commit to gravyboat/insomnia that referenced this pull request Feb 9, 2021
@MrSnix @develohpanda @gravyboat
Updating webpack configuration for development (Kong#3043)
06a32f5 
Co-authored-by: Opender Singh <opender.singh@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@develohpanda develohpanda develohpanda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MrSnix @develohpanda