Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split url into components on a service #3314

Merged
merged 6 commits into from Apr 23, 2021
Merged

split url into components on a service #3314

merged 6 commits into from Apr 23, 2021

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Apr 22, 2021

  1. the generated service entity would have a url field. This field is only a sugar-field for Kong since it internally only stored the individual components of the url. The effect of this is when a generated config is synced to Kong, the provided config will have a url field where the Kong config will have host, path, etc., and hence the comparison will always fail, and it will always be marked in the diff and synced, despite that the end result would be identical. By splitting the url already in the generated config, this noise will be gone.

  2. fixes a bug; now uses the upstream name in a service instead of an actual hostname from the servers block

  3. fixes a bug; if a server was specified as a path only, then a target would be generated as "null:null", now it will simply not create any targets

(against Insomnia v2021.3.0-beta.1)

Fixes INS-556

also fixes a bug to use the upstream name in a service instead
of an actual hostname from the 'servers' block
previously a server with just a path; '/some/path' would generate
a target 'null:null'.
Copy link
Contributor

@sonicyeti sonicyeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@develohpanda develohpanda self-requested a review April 22, 2021 15:32
@vercel vercel bot temporarily deployed to Preview April 23, 2021 00:02 Inactive
@develohpanda
Copy link
Contributor

Nice optimization with option 1. I'm guessing that means faster sync times too huh

@develohpanda develohpanda merged commit e4c7ed2 into develop Apr 23, 2021
@develohpanda develohpanda deleted the split-url branch April 23, 2021 02:41
@Tieske
Copy link
Member Author

Tieske commented Apr 23, 2021

Nice optimization with option 1. I'm guessing that means faster sync times too huh

@develohpanda yes! forgot to mention that 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PA-openapi-2-kong Package: OpenAPI 2 Kong
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants