Skip to content

Tags for all of the plugins! #3328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 27, 2021
Merged

Tags for all of the plugins! #3328

merged 7 commits into from
Apr 27, 2021

Conversation

@develohpanda
Copy link
Contributor

@develohpanda develohpanda commented Apr 27, 2021 •
edited
Loading

Closes INS-629, best examples are through the fixture updates, requirements are outlined in the linked ticket

@develohpanda develohpanda self-assigned this Apr 27, 2021
@develohpanda
Copy link
Contributor Author

develohpanda commented Apr 27, 2021 •
edited
Loading

There are package.json changes included in this PR which are only for the beta build; I wanted to avoid creating a nested release branch. Please ignore those changes, you can review the first four commits only as the package.json changes are only in ab0c314 (#3328).

Tieske
Tieske approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dimitropoulos
dimitropoulos approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@dimitropoulos dimitropoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from x-kong-plugin-request-validator being in the ticket but being handled in a prior commit, it seems that all of the criteria in the ticket was met here. I'll admit I don't deeply deeply understand what's going on but the code looks good and the tests pass and the areas in the ticket seem to be covered.

@develohpanda develohpanda merged commit 69d7514 into develop Apr 27, 2021
@develohpanda develohpanda deleted the feature/ins-629-o2k-support-tags-on-plugins branch April 27, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sonicyeti sonicyeti Awaiting requested review from sonicyeti

2 more reviewers

@Tieske Tieske Tieske approved these changes

@dimitropoulos dimitropoulos dimitropoulos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@develohpanda develohpanda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@develohpanda @Tieske @dimitropoulos