Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spec preview code font color #3369

Merged
merged 1 commit into from
May 13, 2021

Conversation

roguib
Copy link
Contributor

@roguib roguib commented May 9, 2021

This PR should fix #3010 and also #2948 馃帀

In any of the two issues a preferred font color wasn't specified, so I decided to use --color-warning after trying different values and testing it with dark and light themes. Feel free to suggest another font color if it better suits the platform and I'll update the PR ASAP.

The main problem here is that in some themes, usually the light ones, the font color matches the dark background of the editor preview, making the text unreadable. Using another font color solves the issue.

Screenshots Core default:

image

Designer light:

image

Hyper:

image

Solarized Light:

image

@develohpanda develohpanda changed the title fixes #3010 and also fixes #2948 Improve spec preview code font color May 11, 2021
Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR! We have a code-freeze in place at the moment but I will come back and merge it after.

@roguib
Copy link
Contributor Author

roguib commented May 11, 2021

Thanks for the review @develohpanda. I'm aware of the code-freeze, hope the migration to Typescript goes smoothly and without so many headaches! I'm going to look for another issue to work on in the meantime.

@develohpanda develohpanda merged commit 3b75725 into Kong:develop May 13, 2021
@dimitropoulos
Copy link
Contributor

Thanks for your contribution and patience @roguib!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illegible preview markup on light themes.
3 participants