Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show both name and uri during import through insomnia protocol #3407



Copy link

@develohpanda develohpanda commented May 20, 2021

Fixes INS-731

Protocols to test with:

  • live: insomnia://app/import?uri=uri-param&name=name-param
  • this PR: insomniadev://app/import?uri=uri-param&name=name-param (after npm run app-start, go to this URL in your browser)

Users would previously see this:

Users will now see this:

To try with valid import data:

  • live: insomnia://app/import?uri=
  • this PR: insomniadev://app/import?uri=

Note: this PR does not address how the prompt looks, it's already looked bad with a long URL, and looks worse now with the name property.

Copy link

The code certainly looks just fine, but I tried to test this and learned that I can't, for whatever reason, open these links, despite insomnia running.

The manual way on linux would be to call xdg-open directly, and when I do, this happens:

Copy link

@reynolek reynolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on mac

@develohpanda develohpanda merged commit f2609fc into develop May 24, 2021
@develohpanda develohpanda deleted the feature/ins-731-security-vulnerability-with-importing branch May 24, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants