Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response time in api response to test latency #3465

Merged
merged 3 commits into from Jun 11, 2021

Conversation

amaaniqbal
Copy link
Contributor

@amaaniqbal amaaniqbal commented Jun 11, 2021

Closes #3297

@amaaniqbal
Copy link
Contributor Author

@develohpanda I created a PR for #3297. Please have a look!

Copy link
Contributor

@reynolek reynolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @amaaniqbal ! Thanks for the PR. Looking at the code, this is functional and does the requested ask in the open issue.

There is some clean up that I would like to do, mostly around handling the proper types. The function toMs injects an implicit any type, which is one thing we are looking to eliminate going forward. However to fix this, there are larger changes that need to be made in insomnia's networking code, some of which falls out of scope of the PR, and I wouldn't expect any contributor to make those changes.

Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is awesome

@reynolek reynolek merged commit 6df749d into Kong:develop Jun 11, 2021
develohpanda pushed a commit that referenced this pull request Jun 22, 2021
* Add response time in api response to test latency

* linting fixes

Co-authored-by: Eric Reynolds <eric.reynolds@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a response time calculation to test API response latency.
3 participants