Allow optional specification of Origin header for Auth Code flow + PKCE #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @rustybox this certainly works for now. At some point, it may make sense to come back and revisit for a more generic solution but I don't want to let perfect be the enemy of good here. I'll let others do the actual code review as well but thanks for your contribution! 🙌 |
|
Pushed linting fixes and removed some indentation my editor decided to add. Even when custom headers are in I wonder if origin deserves a place in Advanced Options for the signposting, I imagine custom headers would be used more for X-Foo style headers. |
develohpanda
approved these changes
Jul 5, 2021
gatzjames
approved these changes
Aug 9, 2021
|
rebased on develop & resolved conflicts |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #794
@wdawson this is slightly lazier than the approach discussed in #3572 but it feels reasonable to stuff Origin header into the advanced options section.