Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removing header in default header plugin #3791

Merged
merged 8 commits into from Aug 25, 2021
Merged

Allow removing header in default header plugin #3791

merged 8 commits into from Aug 25, 2021

Conversation

ThisNoName
Copy link
Contributor

Default header is global, it might be useful allow removing header using folder environment. For example, most requests require token, but certain section may not.

@vercel vercel bot temporarily deployed to Preview August 10, 2021 11:36 Inactive
use 'null' to explicitly removing header

{
  "DEFAULT_HEADERS": {
    "Authorization": "null"
  }
}
Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and welcome to the project! 🥳

Looks reasonable to me, just one comment. Could you please update the README as well?

use context.removeHeader

Co-authored-by: Opender Singh <opender94@gmail.com>
@vercel vercel bot temporarily deployed to Preview August 18, 2021 20:21 Inactive
Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>
@develohpanda develohpanda enabled auto-merge (squash) August 25, 2021 06:48
@develohpanda develohpanda merged commit fdf89c8 into Kong:develop Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants