Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text/plain body type #3793

Merged
merged 10 commits into from Jul 19, 2021
Merged

Add text/plain body type #3793

merged 10 commits into from Jul 19, 2021

Conversation

theozordako
Copy link
Contributor

@theozordako theozordako commented Jul 6, 2021

This fixes issue with content-type dropdown for text/plain in header of requests and leaves content type "other" untouched.

Copy link
Contributor Author

@theozordako theozordako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import of new Content Type Added

Copy link
Contributor Author

@theozordako theozordako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.
grafik

@develohpanda develohpanda changed the title Closes #3484 This fixes issue with text/plain header content type in requests Add plain text/plain body type Jul 12, 2021
@develohpanda develohpanda changed the title Add plain text/plain body type Add text/plain body type Jul 12, 2021
Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this PR closes what is described in #3484 so have unlinked this PR from the issue. I have asked for some feedback about it, and I'll chime in on the issue once we know how we want to fix it!

That said, this PR looks good to me as just introducing a plain text body type!

image

@vercel vercel bot temporarily deployed to Preview July 12, 2021 21:14 Inactive
@theozordako
Copy link
Contributor Author

@wdawson @dimitropoulos Could you please review this pull-request? Just 4 lines of code ;) Thx.

Copy link
Contributor

@wdawson wdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as well. Thanks for the quick add @theozordako

@vercel vercel bot temporarily deployed to Preview July 19, 2021 22:13 Inactive
@develohpanda develohpanda enabled auto-merge (squash) July 19, 2021 22:15
@develohpanda develohpanda merged commit 4500057 into Kong:develop Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants