Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response Timer: Tabular Nums Styling #3800

Merged
merged 1 commit into from Jul 10, 2021
Merged

Response Timer: Tabular Nums Styling #3800

merged 1 commit into from Jul 10, 2021

Conversation

lusbuab
Copy link
Contributor

@lusbuab lusbuab commented Jul 9, 2021

This prevents the timer to constantly change its width → the text doesn't jump anymore.

BEFORE

Screen.Recording.2021-07-09.at.9.30.25.PM.mov

AFTER

Screen.Recording.2021-07-09.at.9.31.42.PM.mov

@reynolek
Copy link
Contributor

reynolek commented Jul 9, 2021

This is one of those fixes I didnt realize I needed until I saw the difference. Nice work! I've requested a review from one of the devs.

Thanks for the contribution!

Copy link
Contributor

@dimitropoulos dimitropoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, great. There's a CSS property for everything, isn't there? :)

works great on my machine:

2021-07-09.17-52-14.mp4

Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@reynolek reynolek merged commit 92e0970 into Kong:develop Jul 10, 2021
@reynolek
Copy link
Contributor

Thanks for the contribution!

Be sure to apply for your Insomnia contributor shirt!

@lusbuab
Copy link
Contributor Author

lusbuab commented Jul 10, 2021

Thanks @reynolek @dimitropoulos @develohpanda, I really appreciate how responsive you are! ❤️

@lusbuab lusbuab deleted the patch-1 branch July 17, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants