New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin API feature: added getInfo method to context.app #3975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! One small update, please 🙌🏽
Looks like there are a couple of lint errors too, they can be auto-fixed by running npm run lint:fix
from the root of the repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange how there were some additional lint changes that went in; how did you run lint fix? Was it npm run lint:fix
from the root directory of this project?
Anyway that's okay, I reverted those. Thank you for adding tests! LGTM
Yes, I ran it like that but I also thought it was strange how it changed functions into arrow functions and just not accepting them otherwise. Maybe there's something wrong with my setup. Sorry about that, and glad I could help! |
That's all good! I'll have a look at it 😊 |
while making a plugin to test #3975 I happened to just randomly select `insomnia-plugin-file`'s package.json and noticed this typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to go!
I noticed there is a z-index problem, but that isn't related to what this PR implements:
version
,ID
,name
andplatform
using the helper methods fromcommon/constants