Environments order

[vincendep]

Closes #3922
Closes #3822
Closes INS-954

[dimitropoulos]

Thanks! I tested using the steps in #3822 and can confirm that this PR fixes what's described in those steps.

Here's what I tested with:

[vincendep]

Hi @dimitropoulos. I also include a change to address issue #3922, but I was not sure if it was a good idea since there were no feedback from you under that

[dimitropoulos]

@vincendep is it something different than this fix? if so, it'd be great if you knew the reproduction steps (and would open a new PR for that issue so we can handle separately).

[vincendep]

It is quite related, since I had to update my previous changes.

[develohpanda]

On testing this seems to work well! A couple of notes however, would love your thoughts!

[develohpanda]

I'm just curious on what purpose this serves specifically? It's worth writing a comment here to explain why the metaSortKey for the base environment should be hard-coded to 0.

[develohpanda]

I think setting this to just idx should do the job. Looking at where this regression was introduced, that was the existing behavior: https://github.com/Kong/insomnia/pull/2891/files?authenticity_token=NotWiXgjksFGynH9ySdJfzuPFfvny1ipT861Ia0PCdxxQciOP08il4GzvolDtfnjCbgSLI7MzW3fm3gge3EmMQ%3D%3D&file-filters%5B%5D=.tsx#diff-83bf0bed6b835cb203957ba0b8b615b662856919617cab840b6ced94a9d02708L337-R375. During the refactor, metaSortKey: i was mistakenly changed to metaSortKey: 1.

insomnia/packages/insomnia-app/app/ui/components/modals/workspace-environments-edit-modal.tsx

Lines 337 to 346 in ce9637e

	for (let i = 0; i < newSubEnvironments.length; i++) {
	const environment = newSubEnvironments[i];
	await this._updateEnvironment(
	environment,
	{
	metaSortKey: i,
	},
	false,
	);
	}

Is the + 1 strictly necessary?

[vincendep]

Hi @develohpanda, I introduced that changes after looking at issue #3922. It is to keep the base environment metaSortKey always lower than the sub environment ones.

[develohpanda]

Hi @develohpanda, I introduced that changes after looking at issue #3922. It is to keep the base environment metaSortKey always lower than the sub environment ones.

Gotcha, thanks! I think we should remove the hard-coded value there and stick with what was there before, for the base environment. The metaSortKey for the base environment holds no significance, so while it's likely harmless to change it it doesn't feel like there's a compelling reason to change it.

The extra note in #3922 mentions the re-ordering issue, which is fixed by this PR, but that's not directly related to the base environment metaSortKey, only the sub environment ones.

How does that sound?

[vincendep]

It sounds good to me, indeed I was not sure of the utility to have the metaSotKey of the base environment lower than others. So I'll remove the hard coded one and set back the others to index instead of index plus 1

[gatzjames]

Good one! LGTM!