Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (style): set drag-sidebar z-index to 999 #4059

Merged
merged 5 commits into from
Oct 18, 2021

Conversation

alk-mandrianarijaona
Copy link
Contributor

@alk-mandrianarijaona alk-mandrianarijaona commented Sep 29, 2021

modal globalZIndex starts at 1000 (

)
and anything with z-index >= 1000 will not be under overlay the first time a modal is open.

Each time a modal is opened, the value of globalZIndex is incremented so this issue happens only one time (c.f

)

Closes #4018

modal `globalZIndex` starts at 1000 (https://github.com/Kong/insomnia/blob/d53ef39c9b76aefcfa71630078d838bb95eaad56/packages/insomnia-app/app/ui/components/base/modal.tsx#L11)
and anything with z-index >= 1000 will not be under overlay the first time a modal is open

fixes Kong#4018
@dimitropoulos
Copy link
Contributor

Do you have any idea why this only happens when you first launch the app?

@alk-mandrianarijaona
Copy link
Contributor Author

alk-mandrianarijaona commented Sep 29, 2021

Do you have any idea why this only happens when you first launch the app?

@dimitropoulos Yes it is because we increment the value of globalZIndex each time we open a modal, so the second time, it's greater than 1000 and there is no issue anymore
c.f

@alk-mandrianarijaona
Copy link
Contributor Author

I updated the PR description to make it clearer

Copy link
Contributor

@dimitropoulos dimitropoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great find. I added some documentation. we'll have someone else from the team also take a look then this'll be ready to merge. thanks!

@vercel vercel bot temporarily deployed to Preview October 18, 2021 00:32 Inactive
Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR

@develohpanda develohpanda enabled auto-merge (squash) October 18, 2021 00:37
@develohpanda develohpanda merged commit a23e82d into Kong:develop Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document/Collection settings modal an interact with panels beneath it
4 participants