Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fonts settings UI changed #4186

Merged
merged 10 commits into from Nov 25, 2021
Merged

fonts settings UI changed #4186

merged 10 commits into from Nov 25, 2021

Conversation

sergiyladnych
Copy link
Contributor

@sergiyladnych sergiyladnych commented Nov 7, 2021

This PR Closes #2279. It was changed UI element to set Interface and Editor fonts from Dropdown to Text Input. Help texts were added for both.

Before After
Screenshot before Screenshot after

@wdawson
Copy link
Contributor

wdawson commented Nov 8, 2021

Thanks for the PR @sergiyladnych ! Could you please include some screenshots of the app before and after like in this PR?

@develohpanda develohpanda self-requested a review November 9, 2021 10:01
@sergiyladnych
Copy link
Contributor Author

sergiyladnych commented Nov 9, 2021

Thanks for the PR @sergiyladnych ! Could you please include some screenshots of the app before and after like in this PR?

Done. I have updated initial comment.

@sergiyladnych
Copy link
Contributor Author

@develohpanda hello. I'm curious, is there any difficulties to do review of the PR?

Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I tested and reviewed, and have made a couple of text updates to the tooltip messaging. In a future PR I think we can drop font-scanner entirely 🎉

2021-11-18 13 31 28

Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jackkav jackkav enabled auto-merge (squash) November 25, 2021 09:56
@jackkav jackkav merged commit 1d3cbd3 into Kong:develop Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow controls the font family
4 participants