Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP/V2PriorKnowledge #4194

Merged
merged 7 commits into from
Nov 16, 2021
Merged

Conversation

cgiraldo
Copy link
Contributor

@cgiraldo cgiraldo commented Nov 9, 2021

Closes #3163

Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🚀

@develohpanda
Copy link
Contributor

Hi @cgiraldo! #4177 was just merged into develop, which slightly refactors this area of code hence the conflicts. Should be fairly straightforward to resolve, apologies for the conflict!

@cgiraldo
Copy link
Contributor Author

@develohpanda , I resolved the conflict.
KR

@cgiraldo
Copy link
Contributor Author

Sorry, I accidentally removed the case HttpVersions.V2PriorKnowledge: when resolving the conflict.
With the last commit, the tests should now pass.

Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@develohpanda develohpanda enabled auto-merge (squash) November 16, 2021 19:22
@develohpanda develohpanda merged commit 23d17bc into Kong:develop Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insomnia - forcing requests directly to HTTP2 instead of upgrade from HTTP 1.1
3 participants