Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/upgrade-electron-12 #4232

Merged
merged 11 commits into from
Dec 21, 2021
Merged

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Nov 19, 2021

changelog(Improvements): Upgraded to Electron 12
Follow up from #4230
Retry of: #4160

Upgrades

  • electron 11.2.3 -> 12.2.3
  • node 12.18.3 -> 14.16.0
  • node-libcurl -> kong/node-libcurl@2.3.4-0 fork

Closes INS-1123

Waiting on #4305

  • set electron version to 12.2.3
  • update ['@babel/preset-env',{targets: {electron: '11.2.3'}}], to 12.2.3
  • set node version in nvm to 14.16.0
  • bump node-libcurl to 2.3.4-0
  • clean and bootstrap after rebase

@vercel vercel bot temporarily deployed to Preview November 19, 2021 10:54 Inactive
@jackkav jackkav marked this pull request as draft November 19, 2021 13:46
@vercel vercel bot temporarily deployed to Preview December 2, 2021 12:06 Inactive
@jackkav jackkav marked this pull request as ready for review December 14, 2021 00:32
@vercel vercel bot temporarily deployed to Preview December 17, 2021 13:41 Inactive
@vercel vercel bot temporarily deployed to Preview December 17, 2021 13:51 Inactive
@vercel vercel bot temporarily deployed to Preview December 17, 2021 13:55 Inactive
Copy link
Contributor

@dimitropoulos dimitropoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are on electron-context-menu at ^2.2.0 (resolving to 2.5.2) and the latest (https://github.com/sindresorhus/electron-context-menu/releases) is 3.1.1. It looks like the 3.0 had a fix "Fix Electron 12 compatibility" sindresorhus/electron-context-menu#139 that we're gonna need.

Copy link
Contributor

@dimitropoulos dimitropoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're on electron-log ^4.3.5 (resolving to 4.3.5), and 4.4.3 is the latest. It contains two fixes that I wanted to double-check we don't need:

might be worth upgrading since we're so close.

Copy link
Contributor

@dimitropoulos dimitropoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're on electron-updater ^4.3.9 (resolving to 4.3.9), and 4.6.5 is the latest. There are two notable items I see in the changelog (https://github.com/electron-userland/electron-builder/blob/master/packages/electron-updater/CHANGELOG.md) since then:

@dimitropoulos dimitropoulos merged commit 21ab3dd into Kong:develop Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants