-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/upgrade-electron-12 #4232
Chore/upgrade-electron-12 #4232
Conversation
2b15484
to
1d9bf0f
Compare
1d9bf0f
to
e884080
Compare
e884080
to
d1e8bd3
Compare
d1e8bd3
to
5d1921c
Compare
5d1921c
to
56b6f16
Compare
56b6f16
to
7f0197d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are on electron-context-menu
at ^2.2.0
(resolving to 2.5.2
) and the latest (https://github.com/sindresorhus/electron-context-menu/releases) is 3.1.1
. It looks like the 3.0 had a fix "Fix Electron 12 compatibility" sindresorhus/electron-context-menu#139 that we're gonna need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're on electron-log
^4.3.5
(resolving to 4.3.5
), and 4.4.3
is the latest. It contains two fixes that I wanted to double-check we don't need:
might be worth upgrading since we're so close.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're on electron-updater
^4.3.9
(resolving to 4.3.9
), and 4.6.5
is the latest. There are two notable items I see in the changelog (https://github.com/electron-userland/electron-builder/blob/master/packages/electron-updater/CHANGELOG.md) since then:
4.5.2
lists: 🚀 2023.5.0-beta.8 #6212 0c21cd69 Thanks @johnnyopao! - Fix upgrade flows on intel mac when both x64 and arm64 versions published4.6.5
lists: Is there any way to add dependencies in Test tab (chai) #6381 828fcd37 Thanks @zhanjinfeng! - fix: use uname -a to get arch instead of 'process.arch' in mac silicon
5b37a56
to
5f4cc48
Compare
5f4cc48
to
81f18b0
Compare
(and co-dependency electron-builder-squirrel)
(and fixes package-lock merge conflicts)
81f18b0
to
db05be4
Compare
changelog(Improvements): Upgraded to Electron 12
Follow up from #4230
Retry of: #4160
Upgrades
Closes INS-1123
Waiting on #4305
['@babel/preset-env',{targets: {electron: '11.2.3'}}],
to12.2.3