Import multiple envs when importing OpenAPI3 #4254
Conversation
|
Really looking forward to using this, thank you! |
| const basePath = (currentServerUrl.pathname || '').replace(/\/$/, ''); | ||
| const openapiEnv: ImportRequest = { | ||
| _type: 'environment', | ||
| _id: 'env___BASE_ENVIRONMENT_ID___sub', |
There was a problem hiding this comment.
This will cause all of the sub environments to have the same id and insomnia won't see them as unique.
In other areas we append a hash of the dependent property to make the id deterministic and unique. What would be a dependent property here - the URL? Ie. if the server URL changes, a new sub environment will be created.
There was a problem hiding this comment.
Nice catch. I'll fix it.
| _type: 'environment', | ||
| _id: 'env___BASE_ENVIRONMENT_ID___sub', | ||
| parentId: baseEnv._id, | ||
| name: 'OpenAPI env', |
There was a problem hiding this comment.
Same note as above, the name for each sub environment will be OpenAPI env. What would you expect the environment created from each new server to be named?
| @@ -10,3 +10,92 @@ describe('Import errors', () => { | |||
| } | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Import OpenApi', () => { | |||
There was a problem hiding this comment.
Any particular reason you chose to add tests like this instead of adding to the fixtures in packages/insomnia-importers/src/importers/fixtures/openapi3?
There was a problem hiding this comment.
No particular reason, just didn't understand the test mechanism. So I wrote this one.
I'll do it in the same way as the other tests.
sixdouglas
force-pushed
the
feat/openapiMultipleServersImport
branch
from
b737207 to
04fc821
Compare
filfreire
added
the
insomnia-stream
|
This would be really useful for getting Insomnia into my organisation. Is there something I can do to help get this finished? I'm not sure what's left to do. |
|
I also hope to have this improvement in Insomnia. |
|
This feels very necessary to work with insomnia when our primary source is OpenAPI. Is there a problem with the PR? |
filfreire
force-pushed
the
feat/openapiMultipleServersImport
branch
from
9c8f007 to
26727c4
Compare
filfreire
removed
the
insomnia-stream
There was a problem hiding this comment.
Sorry for the long wait @sixdouglas
Rebased with latest develop and fixed lint and tests.
Tested locally, LGTM! Waiting for someone else from @Kong/team-insomnia to give the 👍
filfreire
force-pushed
the
feat/openapiMultipleServersImport
branch
2 times, most recently
from
5aa1e70 to
e592ea6
Compare
filfreire
force-pushed
the
feat/openapiMultipleServersImport
branch
from
e592ea6 to
a447cb9
Compare
* feat(import): import multiple envs when importing OpenAPI3 When the OpenApi file to import contains multiple servers, import each one as an environment. Closes Kong#3627 * feat(import): import multiple envs when importing OpenAPI3 When the OpenApi file to import contains multiple servers, import each one as an environment. Closes Kong#3627 * fix lint and tests & rebase with latest develop Co-authored-by: SIX Douglas <douglas.six@ext.adeo.com> Co-authored-by: Filipe Freire <livrofubia@gmail.com>
changelog(Improvements): Each OpenAPI server is now imported as a sub-environment
When the OpenApi file to import contains multiple servers, import each one as an environment.
Closes #3627