Cleanup extra 'v' in version of the document card #4319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't easily find anywhere to add a test. Is there anything I can add to? |
filfreire
requested changes
Dec 17, 2021
filfreire
added
T-tested-by-author
dimitropoulos
approved these changes
Dec 21, 2021
|
@filfreire , seems like the team is aligned that this is better than what we have and we will follow up later with additional improvements. Does that sound good to you? |
|
<discussed and the team agreed in standup that since we all agree that what's in this PR is at least better than what we have right now, we're going to merge as is and keep an eye open for the future on making this even better> |
|
Thanks for the tests @dimitropoulos ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): An extra
vwill no longer appear in the dashboard for a Design Document's version if the version already starts withvTook the quick fix path for this issue for now. As noted in the issue, we want to improve this eventually to more clearly show that it's metadata and pull the value directly. But this is the solution we want for now.
https://www.loom.com/share/5971e8b2100c4a96a114fc0ecc04f7b9?sharedAppSource=team_library
Resolves INS-1277