Always generate base environment id when importing

[vincendep]

changelog(Fixes): Fixed an issue that caused dangling base environments when importing an Insomnia collection

This pull request ensures the "regeneration" of the base environment id when importing a collection.
Preventing the creation of an additional base environment, will be possible to import into an existing collection (modifying the export file) without losing all the exported environments .

Closes #4178

[filfreire]

Possibly linked with #3112

[vincendep]

Hi @dimitropoulos and @filfreire . I just saw the stream and I'll try to clarify.
I was trying to replace the base environment _id property with the placeholder (and therefore also the parentId property of subenvironments since they have a parent-child relation) thus, in case of manually editing the workspaceId in the export file, the right id would be picked during the import phase.

Said that, this code is buggy and so the draft status. Also I don't know if actually make sense to support such a usecase of manually editing the export file, given that now is also present a functionality to import into an existing workspace.

[filfreire]

heads up @Kong/team-insomnia I added a unit test that reproduced the previous faulty behavior. The edge case was such that when reimporting we would end up with dangling environments which the user could no longer interact with.

[filfreire]

@vincendep thanks for contributing this and sorry for the long wait on the merge. In the meantime I added tests 👍

This will go in the next release.

[vincendep]

Hi @filfreire. No problem, happy to contribute. 😁