fixes colorblind theme name and adds tests to prevent it happening again #4525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitropoulos
force-pushed
the
fix/colorblind-name
branch
from
05543cc to
ab0e188
Compare
because... why not.
filfreire
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While pairing on something unrelated with @gatzjames, we noticed that the colorblind theme has a malformed CSS class name:
Whitespace in CSS classes are not valid. Ultimately, though, the problem is as much one of communication (to plugin authors) as anything else. So this PR implements a console error (rather than throwing) that theme plugin developers would see when developing.
To make sure this logic stays consistent, there are tests for this check. Then, I fix the error for the colorblind theme by modifying its name. The name selected doesn't match the order pattern we use for all other themes (i.e. it used
dark-colorblindinstead ofcolorblind-darklike for all other themes) so since I had to change the name I made it consistent with the rest.changelog(Fixes): The colorblind theme had a malformed identifier. If you were using this theme, you'll need to re-select in the theme switcher.