Conversation
jackkav
force-pushed
the
chore/upgrade-electron-15
branch
from
185b132 to
47d7ee6
Compare
jackkav
force-pushed
the
chore/upgrade-electron-15
branch
from
47d7ee6 to
1008791
Compare
jackkav
force-pushed
the
chore/upgrade-electron-15
branch
from
1008791 to
96a93cd
Compare
jackkav
force-pushed
the
chore/upgrade-electron-15
branch
from
828970a to
63afdc0
Compare
jackkav
requested review from
dimitropoulos,
filfreire,
gatzjames and
johnwchadwick
| console.log(`[build] npm: ${childProcess.spawnSync('npm', ['--version']).stdout}`.trim()); | ||
| console.log(`[build] node: ${childProcess.spawnSync('node', ['--version']).stdout}`.trim()); | ||
|
|
||
| if (process.version.indexOf('v14.') !== 0) { |
There was a problem hiding this comment.
out of scope, perhaps, but we can get this from the package.json.engines field (or the nvmrc or something like that). maybe we should in the future after this PR so this becomes parametric?
There was a problem hiding this comment.
I guess we can probably remove this entirely instead since we run the check-version.js script as part of bootstrap anyway, which does use .nvmrc?
There was a problem hiding this comment.
I mean... while we're on the topic, what's stopping us from using the engines package.json field?
I hit this problem all the time where I (with the wrong node version) run npm run clean, which succeeds, then run npm run bootstrap which fails, but then if I try to run npm run clean again, it fails again because now it can't find lerna because it just deleted it. In practice, this happens when I run the npm run hard-reset command, which I use many times per day every day. Having an engines field would mean the check would happen before npm run clean and thus the problem would go away. But anyway..
4 participants
TODO:
.now()changelog(Improvements): We've upgraded to Electron 17. While this change should not affect any behavior of the app, please reach out to us if you run into any problems so that we can assist.