Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concating x-kong-security-openid-connect config with security schemas… #4607

Merged
merged 10 commits into from
Mar 29, 2022

Conversation

dmortim
Copy link
Contributor

@dmortim dmortim commented Mar 18, 2022

Related to #4572

This will enable us to set more configuration properties that is available from the OIDC plugin in Kong. Currently, the OAS3 security schema object for openIdconnect configuration is replaced by the x-kong-security-openid-connect config, which removes scopes_required and the issuer that are set by the security property (on operations) and the openIdConnectUrl respectively.

The documentation states the following, which does not seem to be happening currently Security Plugins Docs

The additional properties that Kong supports on its plugins can be 
configured by using custom extensions. The custom extensions are
x-kong-security-<plugin-name>.

Note: I don't write javascript / typescript so there may be a better way of achieving this for all x-kong-security extension configs.

Changelog(OpenAPI-2-Kong): Fixed an issue where we were not concatenating x-kong-security-openid-connect config with security schemas when generating declarative Kong configs

@dimitropoulos dimitropoulos added the insomnia-stream a good candidate to look at during the weekly livestream (see #stream on https://chat.insomnia.rest) label Mar 18, 2022
@filfreire
Copy link
Member

@dmortim thank you for contributing this!

Me and @dimitropoulos paired reviewed this in our latest Insomnia live stream.

We added a small improvement, and a unit test.

@filfreire filfreire enabled auto-merge (squash) March 29, 2022 11:22
@filfreire filfreire merged commit 17f0a43 into Kong:develop Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
insomnia-stream a good candidate to look at during the weekly livestream (see #stream on https://chat.insomnia.rest)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants