Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dialogs for the response web view #4642

Merged
merged 4 commits into from
Mar 29, 2022

Conversation

DMarby
Copy link
Contributor

@DMarby DMarby commented Mar 25, 2022

Prevents the app from getting stuck in a constant error loop when an error is produced by the response web view, eg when a website is trying to access localStorage.

Fixes #4638

changelog(Fixes): Prevent the app from getting stuck in a constant error loop when an error is produced by the response web view, e.g. when a website is trying to access localStorage

Copy link
Member

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do the trick for the page reported on #4638
Screenshot 2022-03-28 at 09 27 50

@DMarby DMarby marked this pull request as ready for review March 28, 2022 14:18
@DMarby DMarby enabled auto-merge (squash) March 29, 2022 11:59
@DMarby DMarby disabled auto-merge March 29, 2022 11:59
@DMarby DMarby enabled auto-merge (squash) March 29, 2022 11:59
@DMarby DMarby merged commit 49b97aa into develop Mar 29, 2022
@DMarby DMarby deleted the feature/localstorage-error-alerts branch March 29, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SessionStorage read error when loading an html page request in visual preview
2 participants