-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Publish Inso CLI docker images (INS-1238) #4722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish Inso CLI docker images (INS-1238) #4722
Conversation
| DOCKER_REGISTRY_USER: ${{ secrets.DOCKER_REGISTRY_USER }} | ||
| DOCKER_REGISTRY: docker.io | ||
| DOCKER_IMAGE: kongcloud/insomnia-inso | ||
| DOCKER_LATEST_TAG: ${{ env.IS_PRERELEASE == 'false' && 'latest' || contains(github.event.inputs.version, 'alpha') && 'alpha' || 'beta' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use this for the latest-like tags besides the specific version tags.
- If it's a stable release - we'll update the
latesttag - If it's a beta or alpha release - we'll update
betaoralphatags respectively (acting as alatesttag for beta/alpha track
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM.
|
tell me if this is out of scope: but I'm worried that this will break in the future and we won't know. is there some way to do a quick sanity check on the completed image to verify it works? |
johnwchadwick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/insomnia-inso/Dockerfile
Outdated
| COPY ./artifacts/inso-linux-*.tar.xz /tmp/inso.tar.xz | ||
| RUN tar -C /usr/bin -xvf /tmp/inso.tar.xz | ||
|
|
||
| FROM docker.io/alpine as binary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: It might? be a good idea to pin an exact alpine release here. I don't anticipate this will ever be an issue, though.
I agree with this sentiment in general. I think it's out of scope for publishing/this PR, we intentionally don't run tests in these workflows to keep them simple, quick and error-free, but it would be good to create a linear ticket to follow up on this, as we have similar issues for other publishing methods as well, eg ensuring installing inso and running it from |
|
@DMarby @dimitropoulos I've added a new linear issue to triage to follow-up on doing sanity checks for the inso docker image - INS-1525 @johnwchadwick I agree with pinning alpine to a proper version, will edit the PR. |
This PR adds needed functionality for us to start publishing
inso-clidocker images.How to test docker image locally:
packages/insomnia-inso/artifacts/folder.insocommands by mounting on folder where you have.insomniadata, e.g.:docker run -it --rm -v $(pwd):/var/temp insomnia-inso:latest generate config -w /var/temp -f jsonchangelog(Improvements): We now publish Docker images for Inso CLI at https://hub.docker.com/r/kong/inso