Feature/ins-1518-improve-create-request-dropdownmodal

[jackkav]

Request shortcuts in new request/folder dropdown. It was hard to find gRPC when it was nestled in the http methods dropdown. This aims to raise the discoverability of gRPC, GraphQL and in future websockets.

Changes

• New request modal previously showed mime type selection on post put and patch hiding it for other methods, this isn't suitable for graphql. Therefore I have elected to remove the hiding and showing of the mime type selection in order to simplify the use cases of this form.

Friction

• the existing mime type show/hide UX is too twitchy, there is only one reasonable case for it to be disabled/hidden which is grpc, however I would argue this is still the wrong place for GRPC to go since the other options are all HTTP methods. This logic holds true for websockets too. Therefore I have gone with the approach above.
• there's a lot of prop drilling and indirection in this code path, related to hotkeys.
• open to suggestions about default hotkeys for grpc and graphql...
• the ticket INS-1518 suggests removing the New Request modal flow entirely but that would conflate insomnia approach to request naming, that could be scoped out of this PR and still deliver on increased discoverability. However removing modal code could be a "good thing ™" since we have issues with the implementation of modals.

New Dropdown

Old Modal

Update: removed new request modal
In light of this change a few new issues arise.
Friction

• new folder flow is now inconsistent and has different rename flow.
• grpc still has a set proto modal, which could be delayed until the url is filled out.
• quick create request hotkey is now identical to create request, so I've renamed it to create http request.
• should folder context menu also contain these quick request types? Not yet.
• should I transform the two dropdown components to function components? would entail untangling the dropdown hide show ref drilling.

changelog(Improvements): Improved the create new request shortcuts dropdown

[dimitropoulos]

hey: reminder that we want analytics events for stuff like this

[gatzjames]

Seems that most of the friction points have been moved to new issues 👏
Imo migrating the dropdown seems like a big task for this PR so we could keep it out of scope for now.
Tested and it works great! 🚀

[jackkav]

Tested analytics from new request in folder, add button and empty state. All send successfully @dimitropoulos

[dimitropoulos]

I know I know we're trying to get this PR over the line and I hate having to ask this.. but what's the story with the request group menu not having the graphql and grpc items anymore in the last commit? Apologies if I missed it somewhere.

---

Also, independent of that, the change to put unbound functions in callbacks (e.g. onClick={() => someThing()}}) has pretty sever performance problems it presents (over time, especially).

---

I did, however, confirm that the segment events area all working now, so that's good at least.

[jackkav]

It wasn't in the ticket, so I thought to add it if it was straightforward. However once I did the number of new decisions to make increased the scope too much for a single PR.

no longer relevant