Skip to content

bump node and electron 19 #4847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Jun 8, 2022

https://www.electronjs.org/releases/stable#19.0.0

TODO:

  • add electron 19 to node-libcurl fork

changelog(Improvements): Upgraded to Electron 19

@jackkav jackkav changed the title bump node and electron bump node and electron 19 Jun 8, 2022
@jackkav jackkav requested a review from dimitropoulos June 8, 2022 13:44
@jackkav jackkav force-pushed the chore/bump-electron-19 branch from 7c6a2b7 to edd92a8 Compare June 8, 2022 16:22
@jackkav jackkav marked this pull request as ready for review June 8, 2022 16:46
@jackkav jackkav requested a review from filfreire June 8, 2022 16:46
@jackkav jackkav self-assigned this Jun 8, 2022
@jackkav jackkav force-pushed the chore/bump-electron-19 branch from edd92a8 to 298c573 Compare June 8, 2022 18:08
@jackkav jackkav requested review from marckong and DMarby June 8, 2022 19:20
Copy link
Contributor

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! From my side I think we can merge this one.

There was something weird happening, at first I thought it was specific to a PR with latest build like this one:

Take a request like this:

curl --request GET \
  --url 'http://mockbin.org/request/anything?test=test&test2=asaa&foo=baar' \
  --header 'Authorization: Basic YWFhOmFhYQ==' \
  --header 'Content-Type: multipart/form-data' \
  --header 'test: mctest' \
  --form test=test

In latest beta, it seemed to work fine:
image

In this PR's build, there seemed to be something weird happening:
image

BUT, I was wrong, it's an unrelated issue with mockbin.org itself.

When I first was building out the request, I set the Authorization as Digest, which seems to make mockbin.org return back the 503 heroku failure page, regardless of these changes.

It may screw up the HTTP connection that can be reused for any subsequent request, despite us disabling Authorization afterwards. It works again by forcing a new HTTP connection (e.g. by changing https://) and picking another Authorization method for the given domain we're trying to hit.

Using another bin that has proper support for Digest auth httpbin.org/digest-auth/auth/aaa/aaa, shows it working:

image

@jackkav jackkav merged commit 28acc69 into Kong:develop Jun 9, 2022
@jackkav jackkav deleted the chore/bump-electron-19 branch June 9, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants