-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved accessibility for activity toggle. #4928
Conversation
This looks good to me. I added some changes to this PR though (it seems to be the custom in Insomnia we push to the PR branch directly). These are the changes;
|
packages/insomnia/src/ui/components/activity-toggle/activity-toggle.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
This looks and works great and it's always nice to see contributions that improve the app's accessibility!
@gatzjames Don't mention. It's my pleasure! |
Changes activity toggle component to use Links for changing the active activity.
This makes the activity toggle keyboard accessible.
Closes #4927
Changelog(Improvements): The activity toggle is now keyboard accessible