Improved accessibility for activity toggle.#4928
Merged
Merged
Conversation
marckong
approved these changes
Jul 8, 2022
Contributor
|
This looks good to me. I added some changes to this PR though (it seems to be the custom in Insomnia we push to the PR branch directly). These are the changes;
|
gatzjames
approved these changes
Jul 12, 2022
Contributor
gatzjames
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
This looks and works great and it's always nice to see contributions that improve the app's accessibility!
Contributor
Author
|
@gatzjames Don't mention. It's my pleasure! |
dimitropoulos
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes activity toggle component to use Links for changing the active activity.
This makes the activity toggle keyboard accessible.
Closes #4927
Changelog(Improvements): The activity toggle is now keyboard accessible