Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved accessibility for activity toggle. #4928

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

pavkout
Copy link
Contributor

@pavkout pavkout commented Jul 5, 2022

Changes activity toggle component to use Links for changing the active activity.
This makes the activity toggle keyboard accessible.

Closes #4927

Changelog(Improvements): The activity toggle is now keyboard accessible

@marckong
Copy link
Contributor

marckong commented Jul 8, 2022

This looks good to me. I added some changes to this PR though (it seems to be the custom in Insomnia we push to the PR branch directly). These are the changes;

  • removed the useSelector usages in ActivityToggle component and passed props instead to make this component more independent and easy to test. useSelector does some magic read from the database, which requires domain knowledge and also test setup for the database wire up with redux.
  • added unit test cases to check the rendering and behaviors of the component based on user events.

Copy link
Contributor

@gatzjames gatzjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
This looks and works great and it's always nice to see contributions that improve the app's accessibility!

@pavkout
Copy link
Contributor Author

pavkout commented Jul 12, 2022

@gatzjames Don't mention. It's my pleasure!

@gatzjames gatzjames merged commit 0ab0d72 into Kong:develop Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity toggle isn't keyboard accessible.
4 participants