-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for client certificate authentication during OAuth 2.0 #4961
Conversation
b134975
to
770677a
Compare
Hi @NicholasMata thanks for contributing this PR and reporting the original issue. It might take a while for us to look deeply into this PR. Any chance you can share tips on how to test this PR or resources (e.g. docs, an existing repo, docker container, ...) that would help us experiment with it faster? |
As far as testing with authentication that returns a token I could set something up but might take a while. I have tested against my own organization's authentication server which I can't give access too. But to test the functionality of selecting a certificate you can do the following. Create a new HTTP Request in Insomnia. Then set
If you need to create a certificate you can do the following on macOS. Unfortunately I am not sure the steps for Windows off the top of my head.
|
82c28cc
to
73c5b27
Compare
1e6bacc
to
bc17ef6
Compare
bc17ef6
to
1fa17bc
Compare
9d47e18
to
ddfeb33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog(Improvements): Added support for Client Certificate Authentication during OAuth 2 fetch token
Adds support for Client Certificate Authentication during the OAuth 2 browser popup. This form for authentication is well known and supported by all major browsers (Safari, Chrome, Edge, etc)
This fix will automatically select the first certificate if there is only a single certificate. If there are multiple valid certificates it will prompt the user to select one.
Closes #4960 and possibly #1250