Fix Request Switcher Auto-Focus from CodeMirror#5002
Merged
Conversation
daniel-stoneuk
changed the title
filfreire
approved these changes
Jul 28, 2022
Contributor
filfreire
left a comment
filfreire
left a comment
There was a problem hiding this comment.
Seems to be working ok now 👍 😎
Thank you @daniel-stoneuk
Fixes the input `.focus()` method call. The simplest fix was to revert the change in 3cf464d. There do not seem to be any new problems in the current application from reverting this commit's relevant changes, indicating that the original cause of the bug is no longer present.
gatzjames
force-pushed
the
fix-auto-focus
branch
from
c5d8cfa to
be9a0e6
Compare
gatzjames
approved these changes
Jul 28, 2022
Contributor
gatzjames
left a comment
gatzjames
left a comment
There was a problem hiding this comment.
Nice! +100 for removing the dontFocus prop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): Fixed an edge-case issue where Request Switcher search input would not auto-focus
Fixes the input
.focus()method call. The simplest fix I found was to revert the change in 3cf464d.There don't seem to be any new problems in the current application from reverting this commit's relevant changes. The original source of the bug may no longer be present.
Closes #4797