[INS-1789] Fix issue preventing selection of custom HTTP methods #5086
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): Fixed an issue that prevented choosing and deleting user-created custom HTTP methods
Closes INS-1789
Closes #5083
This PR fixes two regressions:
These issues seem to have spawned from two problems:
recent
andsetRecent
doesn't seem to do what we think it does, and is only "valid for one change", hence why I edited the addition and deletion to rely on localStorage instead. I'm open to suggestions on how to improve this, it felt like a hacky workaround, but I couldn't find another way to make it work due tosetRecent
not working "a second time in a row" for the same time the modal is open.Enter
on the Custom Method modal, it is not seemingly picked up like pressing theDone
button.