Hide the github stars for logged in users #5172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMarby
commented
Sep 12, 2022
|
|
||
| const createSettings = () => { | ||
| const settings = models.settings.init(); | ||
| settings.incognitoMode = true; |
There was a problem hiding this comment.
This is to avoid needing to mock fetch in the github stars component for now.
filfreire
approved these changes
Sep 13, 2022
filfreire
force-pushed
the
feature/ins-1790-hide-github-stars-for-users-that-are
branch
from
5669f52 to
18d93ab
Compare
filfreire
deleted the
feature/ins-1790-hide-github-stars-for-users-that-are
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes INS-1790
Changelog(Improvements): The GitHub stars count is now hidden when users are logged in