Fixes #5218, where nested environment variables on a sub environment don't always work #5219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @filfreire I know you verified this bug in #5218 and the next release is imminent. Any chance this PR with the obvious fix (adding an |
filfreire
approved these changes
Nov 10, 2022
…ent don't always work
|
@bbbco this will be merged and added to today's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5218
I opened #5218 today, and decided to dig into this with the debugger. I discovered that we weren't properly
awaiting theasyncfunctionrenderSubContext(). Adding theawaitfixes this issue and deeply nested environment variables work properly.changelog(Fixes): Fixed an issue where deeply nested environments variables didn't work for sub environments