Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INS-2017] add ws subprotocol support #5238

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Oct 3, 2022

the value of this header: sec-websocket-protocol will now be passed to the websocket library as a protocol rather than just as the header.

  • add subprotocol to ws smoke test server

Closes INS-2017

changelog(Improvements): Adding ws subprotocol support

@jackkav jackkav marked this pull request as ready for review October 3, 2022 09:14
@filfreire filfreire changed the title add ws subprotocol support [INS-2017] add ws subprotocol support Oct 3, 2022
Copy link
Member

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

image

@filfreire filfreire merged commit 37a6c83 into Kong:develop Oct 3, 2022
@IfaMinerva
Copy link

IfaMinerva commented Jan 10, 2023

This change causes issues when using custom values for sec-websocket-protocol. If i send somethin like "key, myprotocol" I get the error:
"An invalid or duplicated subprotocol was specified"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants